Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vhdl textio format (output only) #52

Merged
merged 5 commits into from
Mar 25, 2023

Conversation

danselmi
Copy link
Contributor

This generates files which can be used in simulation and synthesis tools.

Where belongs the documentation of the command line parameters? The path mentioned in the Efinix patch looks like it contains only file-format descriptions, instead of SRecord command decriptions...???

@sierrafoxtrot
Copy link
Owner

sierrafoxtrot commented Mar 12, 2023

This generates files which can be used in simulation and synthesis tools.

Where belongs the documentation of the command line parameters? The path mentioned in the Efinix patch looks like it contains only file-format descriptions, instead of SRecord command decriptions...???

The man5 files contain the file descriptions as they are from section 5 "File formats and conventions". The commands themselves are in section 1 "User commands" and the path is documented in doc/man1/*.1.

If you have something specific to e.g srec_cat then it would go in doc/man1/srec_cat.1

If you have something common (primarily the common input arguments used by srec_cat, srec_info and srec_cmp, then it would go into doc/man1/srec_input.1. Generally output specific elements are only used by srec_cat.

@danselmi
Copy link
Contributor Author

I believe this is ready for reviewing too.

Copy link
Owner

@sierrafoxtrot sierrafoxtrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is another fantastic contribution Daniel and sorry for having to wait to the weekend to get to it. I think along the way you also spotted a bug which crept in when --output-block-size was first added back in 2010 (version 1.55). It was always there!

A few minor comments. Happy to discuss as always.

doc/man1/srec_cat.1 Outdated Show resolved Hide resolved
doc/man1/srec_cat.1 Show resolved Hide resolved
srecord/output/file/vhdl_textio.cc Outdated Show resolved Hide resolved
srecord/output/file/vhdl_textio.cc Outdated Show resolved Hide resolved
srecord/output/file/vhdl_textio.h Show resolved Hide resolved
srecord/output/file/vhdl_textio.cc Outdated Show resolved Hide resolved
srecord/output/file/vhdl_textio.cc Outdated Show resolved Hide resolved
@sierrafoxtrot sierrafoxtrot merged commit 80c3f46 into sierrafoxtrot:master Mar 25, 2023
@danselmi danselmi deleted the vhdl_textio branch March 27, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants